Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Rust EncryptionKeyProvider and KeyPair #4771

Merged
merged 7 commits into from
Feb 9, 2024
Merged

Merge Rust EncryptionKeyProvider and KeyPair #4771

merged 7 commits into from
Feb 9, 2024
+277 −430

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Feb 8, 2024 •
edited
Loading

This PR:

  • Merges oak_crypto::encryptor::EncryptionKeyProvider and oak_crypto::hpke::KeyPair into oak_crypto::encryption_key::EncryptionKey
  • Implements serialization/deserialization
  • Implements encryping the private key for Key Provisioning.
  • Removes public keys from EncryptionKey struct (it's only used to be put into the evidence)

Ref #4513

conradgrobler
conradgrobler approved these changes Feb 9, 2024
View reviewed changes
oak_crypto/src/encryption_key.rs Outdated
)
}

// TODO(#4513): Implement `Zeroize` for `EncryptionKey`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinkg the private key already implements it: https://github.com/rozbb/rust-hpke/blob/main/src/dhkex/x25519.rs#L17-L20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

So we don't need to do this manually

Removing the comment

oak_crypto/src/encryption_key.rs Outdated Show resolved Hide resolved
@ipetr0v ipetr0v merged commit 9e03dea into project-oak:main Feb 9, 2024
17 checks passed
@ipetr0v ipetr0v deleted the encryption_key branch February 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradgrobler conradgrobler conradgrobler approved these changes

@tiziano88 tiziano88 tiziano88 approved these changes

@andrisaar andrisaar Awaiting requested review from andrisaar

@jul-sh jul-sh Awaiting requested review from jul-sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipetr0v @tiziano88 @conradgrobler